Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo Setup and Aborting Panic Handler #1

Merged
merged 3 commits into from
Aug 16, 2021
Merged

Repo Setup and Aborting Panic Handler #1

merged 3 commits into from
Aug 16, 2021

Conversation

jcape
Copy link
Contributor

@jcape jcape commented Aug 13, 2021

This PR creates a simple abort-on-panic crate which can be included into an SGX enclave that's already linking to libsgx_trts.a, and compiled with a panic strategy of abort.

@jcape jcape requested review from a team August 13, 2021 19:00
@jcape jcape self-assigned this Aug 13, 2021
@eranrund
Copy link

Nice. Looking forward to seeing the implementation.
The GH actions look call, looking forward to seeing how that works as well.

@jcape jcape marked this pull request as ready for review August 13, 2021 21:54
@jcape jcape changed the base branch from main to develop August 13, 2021 21:58
@jcape jcape enabled auto-merge August 14, 2021 01:46
[![Crates.io Downloads][downloads-image]][crate-link]
[![Build Status][build-image]][build-link]

This crate provides a panic handler implementation intended to be executed inside an SGX enclave. Specifically, it will provide the required `rust_eh_personality()` and `#![panic_handler]` methods to satisfy the linker for a `#![no_std]` environment. As a result, this crate will
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"As a result, this crate will" ...?

@jcape jcape merged commit 6b64bf3 into mobilecoinfoundation:develop Aug 16, 2021
Copy link

@christian-oudard christian-oudard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending the documentation fix mentioned by mfaulk.

@cbeck88
Copy link

cbeck88 commented Aug 16, 2021

I think this is a big regression, we're not logging the panics the way the current mc-sgx-panic crate is. I think we need to revisit this and bring back that functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants