-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo Setup and Aborting Panic Handler #1
Repo Setup and Aborting Panic Handler #1
Conversation
Nice. Looking forward to seeing the implementation. |
[![Crates.io Downloads][downloads-image]][crate-link] | ||
[![Build Status][build-image]][build-link] | ||
|
||
This crate provides a panic handler implementation intended to be executed inside an SGX enclave. Specifically, it will provide the required `rust_eh_personality()` and `#![panic_handler]` methods to satisfy the linker for a `#![no_std]` environment. As a result, this crate will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"As a result, this crate will" ...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pending the documentation fix mentioned by mfaulk.
I think this is a big regression, we're not logging the panics the way the current |
This PR creates a simple abort-on-panic crate which can be included into an SGX enclave that's already linking to
libsgx_trts.a
, and compiled with a panic strategy of abort.