-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure types crates don't use alloc with CI #179
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
6188dbf
to
0f7228c
Compare
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
==========================================
- Coverage 88.08% 87.59% -0.50%
==========================================
Files 41 41
Lines 2653 2668 +15
==========================================
Hits 2337 2337
- Misses 316 331 +15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
de144b6
to
6ed7775
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is basically fine. It would be nice to have a more elegant solution but that doesn't seem to be possible given the current state of tooling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like to think about a few things:
4e9092b
to
1057372
Compare
Update the crates to build with the `thumbv7m-none-eabi` target using only the `core` crate from std
1057372
to
093d8d8
Compare
Update the crates to build with the
thumbv7m-none-eabi
target usingonly the
core
crate from std