Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure types crates don't use alloc with CI #179

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Conversation

nick-mobilecoin
Copy link
Collaborator

Update the crates to build with the thumbv7m-none-eabi target using
only the core crate from std

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Oct 24, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@nick-mobilecoin nick-mobilecoin self-assigned this Oct 24, 2022
@github-actions github-actions bot added the size/L PRs with more than 500 lines of changes label Oct 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #179 (0f7228c) into main (21b6ca2) will decrease coverage by 0.49%.
The diff coverage is 6.25%.

❗ Current head 0f7228c differs from pull request most recent head 5dfbed4. Consider uploading reports for the commit 5dfbed4 to get more accurate results

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   88.08%   87.59%   -0.50%     
==========================================
  Files          41       41              
  Lines        2653     2668      +15     
==========================================
  Hits         2337     2337              
- Misses        316      331      +15     
Impacted Files Coverage Δ
core/build/src/lib.rs 0.58% <0.00%> (-0.06%) ⬇️
core/types/src/lib.rs 100.00% <ø> (ø)
urts/sys/types/src/lib.rs 100.00% <ø> (ø)
core/types/src/error.rs 54.54% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin nick-mobilecoin force-pushed the no_alloc_target branch 2 times, most recently from de144b6 to 6ed7775 Compare October 24, 2022 16:21
@nick-mobilecoin nick-mobilecoin marked this pull request as ready for review October 24, 2022 16:32
Copy link
Contributor

@awygle awygle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is basically fine. It would be nice to have a more elegant solution but that doesn't seem to be possible given the current state of tooling.

Copy link
Contributor

@jcape jcape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like to think about a few things:

core/build/src/lib.rs Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
@github-actions github-actions bot added size/XXL PRs with more than 1000 lines of changes and removed size/L PRs with more than 500 lines of changes labels Oct 24, 2022
Update the crates to build with the `thumbv7m-none-eabi` target using
only the `core` crate from std
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL PRs with more than 1000 lines of changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants