Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sign.rs to sdk-tools #261

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Add sign.rs to sdk-tools #261

merged 1 commit into from
Jan 31, 2023

Conversation

varsha888
Copy link
Contributor

  • Moved sign.rs file from here to sdk-tools
  • Added unit tests

@github-actions github-actions bot added the size/L PRs with more than 500 lines of changes label Jan 25, 2023
@github-actions github-actions bot requested review from jcape and samdealy January 25, 2023 21:55
@varsha888 varsha888 marked this pull request as draft January 25, 2023 21:56
@varsha888 varsha888 force-pushed the sign branch 5 times, most recently from 9b4059c to 711bd9a Compare January 26, 2023 03:01
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023 •
edited
Loading

Codecov Report

Merging #261 (94b266f) into main (6da432a) will decrease coverage by 0.12%.
The diff coverage is 87.93%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   90.30%   90.18%   -0.12%     
==========================================
  Files          45       46       +1     
  Lines        3949     4148     +199     
==========================================
+ Hits         3566     3741     +175     
- Misses        383      407      +24
Impacted Files Coverage Δ
sdk-tools/src/lib.rs 100.00% <ø> (ø)
sdk-tools/src/sign.rs 87.93% <87.93%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@varsha888 varsha888 marked this pull request as ready for review January 26, 2023 17:36
@github-actions github-actions bot requested a review from NotGyro January 26, 2023 17:36
samdealy
samdealy approved these changes Jan 26, 2023
View reviewed changes
sdk-tools/src/sign.rs Outdated Show resolved Hide resolved
sdk-tools/src/sign.rs Outdated Show resolved Hide resolved
@varsha888 varsha888 force-pushed the sign branch 2 times, most recently from cc1848f to f165ae6 Compare January 27, 2023 01:57
nick-mobilecoin
nick-mobilecoin approved these changes Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly suggestions for rustims and general thoughts on the direction the struct(s) might go

sdk-tools/src/sign.rs Outdated Show resolved Hide resolved
sdk-tools/src/sign.rs Outdated Show resolved Hide resolved
sdk-tools/src/sign.rs Outdated Show resolved Hide resolved
sdk-tools/src/sign.rs Outdated Show resolved Hide resolved
sdk-tools/src/sign.rs Outdated Show resolved Hide resolved
sdk-tools/src/sign.rs Outdated Show resolved Hide resolved
sdk-tools/src/sign.rs Outdated Show resolved Hide resolved
sdk-tools/src/sign.rs Show resolved Hide resolved
sdk-tools/src/sign.rs Outdated Show resolved Hide resolved
sdk-tools/src/sign.rs Outdated Show resolved Hide resolved
@varsha888 varsha888 force-pushed the sign branch 2 times, most recently from cd62fb4 to c1f6361 Compare January 31, 2023 00:23
@varsha888 varsha888 mentioned this pull request Jan 31, 2023
Closed
6 tasks
@varsha888 varsha888 force-pushed the sign branch 2 times, most recently from 89e2873 to b5a7b43 Compare January 31, 2023 21:14
@varsha888 varsha888 force-pushed the sign branch 2 times, most recently from 3a2bb0b to d2de5d0 Compare January 31, 2023 21:26
@varsha888 varsha888 closed this Jan 31, 2023
@varsha888 varsha888 reopened this Jan 31, 2023
@varsha888 varsha888 merged commit d23aeef into main Jan 31, 2023
@varsha888 varsha888 deleted the sign branch January 31, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-mobilecoin nick-mobilecoin nick-mobilecoin approved these changes

@samdealy samdealy samdealy approved these changes

@NotGyro NotGyro Awaiting requested review from NotGyro

@jcape jcape Awaiting requested review from jcape

Assignees

@varsha888 varsha888

Labels
size/L PRs with more than 500 lines of changes
Projects
Blockchain Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@varsha888 @codecov-commenter @jcape @samdealy @nick-mobilecoin