Add Deserialize for Quote3<Vec<u8>>
#379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Previously `Deserialize` was only implemented for `Quote3<&[u8]>`. Now it's also implemented for the `Quote3<Vec<u8>>` type.
nick-mobilecoin
force-pushed
the
nick/deserialize-vec-quote
branch
from
c0d2970
to
f3be30c
Compare
nick-mobilecoin
requested review from
eranrund and
dolanbernard
and removed request for
a team
|
The test failures are due to, mobilecoinfoundation/actions#5 |
nick-mobilecoin
commented
Jul 26, 2023
eranrund
approved these changes
Jul 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 87.99% 88.14% +0.14%
==========================================
Files 40 40
Lines 5508 5527 +19
==========================================
+ Hits 4847 4872 +25
+ Misses 661 655 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
Deserializewas only implemented forQuote3<&[u8]>. Nowit's also implemented for the
Quote3<Vec<u8>>type.Motivation
The main MobileCoin repo passes quotes into and out of the enclave. This requires the owned
Quote3<Vec<u8>>version to be serializable as well as the borrowedQuote<&[u8]>version.