Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for v1.9.0 release with updated full-service #330

Merged
merged 3 commits into from
May 8, 2024

Conversation

holtzman
Copy link
Collaborator

@holtzman holtzman commented May 8, 2024

Motivation

In preparing for the MobileCoin blockchain to update to v6.0.0 of Consensus and Fog, Desktop Wallet needs to be re-released with an updated embedded full-service that can attest to the v6.0.0 blockchain.

Since the last Desktop Wallet release, full-service has also included wallet-db changes that will cause any pre-existing wallets to undergo a forced rsync of the wallet-db with the ledger-db. This is a lengthly process that would time out desktop wallets initial connection with full-service

In this PR

This PR

  • updates the embedded full-service to v2.10.1 which is compatible both with MobileCoin core v5.0.0 and Mobile core v6.0.0.
  • updates the Desktop Wallet version string to v1.9.0
  • updates Desktop Wallet to wait for for full-service to resync the wallet-db, if it is doing so on launch.
  • provides notice to the user that the wallet-db is being upgraded, along with progress indication.

Copy link

@jgreat jgreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. I think moving the log level to info is a good call. Debug can leak information.

Copy link

@starkriedesel starkriedesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holtzman holtzman merged commit 698d223 into main May 8, 2024
9 checks passed
@holtzman holtzman deleted the update-full-service branch May 8, 2024 16:05
@holtzman holtzman changed the title prepare for v1.9.0 release with updated full-serivce prepare for v1.9.0 release with updated full-service May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants