Fix list_spendable() to not return inflight txos #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `list_spendable()` would return back an inflight txo if it previously existed in a transaction log that failed. Now `list_spendable()` correctly excludes txos that are in flight.
nick-mobilecoin
requested review from
holtzman,
jgreat,
joekottke,
starkriedesel and
sugargoat
as code owners
|
To view this pull requests documentation preview, visit the following URL: docs.page/mobilecoinofficial/full-service~1008 Documentation is deployed and generated using docs.page. |
holtzman
reviewed
Sep 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
+ Coverage 60.12% 69.05% +8.92%
==========================================
Files 88 125 +37
Lines 12356 16625 +4269
Branches 2010 2791 +781
==========================================
+ Hits 7429 11480 +4051
- Misses 3238 5145 +1907
+ Partials 1689 0 -1689 ☔ View full report in Codecov by Sentry. |
holtzman
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
list_spendable()would return back an inflight txo if itpreviously existed in a transaction log that failed. Now
list_spendable()correctly excludes txos that are in flight.