Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit finalized txo logs from list_spendable() query #1009

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

nick-mobilecoin
Copy link
Contributor

No description provided.

Copy link

docs-page bot commented Sep 19, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/mobilecoinofficial/full-service~1009

Documentation is deployed and generated using docs.page.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.13%. Comparing base (ab2af32) to head (af2c9b6).
Report is 211 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
+ Coverage   60.12%   69.13%   +9.01%     
==========================================
  Files          88      125      +37     
  Lines       12356    16687    +4331     
  Branches     2010     2798     +788     
==========================================
+ Hits         7429    11537    +4108     
- Misses       3238     5150    +1912     
+ Partials     1689        0    -1689     
Flag Coverage Δ
69.13% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@holtzman holtzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this improvement on the calculation of inflight_txo_ids make sense to me.

@nick-mobilecoin nick-mobilecoin merged commit a9bf197 into main Sep 24, 2024
3 checks passed
@nick-mobilecoin nick-mobilecoin deleted the nick/optimize_inflight_txos branch September 24, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants