Only fail transaction logs for specified account. #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when syncing multiple accounts the first account synced would fail expired transaction logs from other accounts. This would result in failing transaction logs that may have actually succeeded. Now only expired transaction logs for the currently processing account will be failed.
nick-mobilecoin
requested review from
holtzman,
jgreat,
joekottke,
starkriedesel and
sugargoat
as code owners
|
To view this pull requests documentation preview, visit the following URL: docs.page/mobilecoinofficial/full-service~1011 Documentation is deployed and generated using docs.page. |
nick-mobilecoin
commented
Sep 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
+ Coverage 60.12% 69.13% +9.01%
==========================================
Files 88 125 +37
Lines 12356 16686 +4330
Branches 2010 2798 +788
==========================================
+ Hits 7429 11536 +4107
- Misses 3238 5150 +1912
+ Partials 1689 0 -1689
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
holtzman
reviewed
Sep 21, 2024
holtzman
reviewed
Sep 21, 2024
add back `+ 1` logic Co-authored-by: Henry Holtzman <henry@mobilecoin.com>
nick-mobilecoin
deleted the
nick/only-fail-tx-logs-for-current-account
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when syncing multiple accounts the first account synced would
fail expired transaction logs from other accounts. This would result in
failing transaction logs that may have actually succeeded. Now only
expired transaction logs for the currently processing account will be
failed.