Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make path in tar consistent, fix missing artifact in release #1016

Merged
merged 1 commit into from
Nov 6, 2024
Merged

make path in tar consistent, fix missing artifact in release #1016

merged 1 commit into from
Nov 6, 2024

Conversation

jgreat
Copy link
Contributor

@jgreat jgreat commented Nov 5, 2024

Motivation

  • looks like --strip-components isn't working on tarball creation in linux. Just create desired directory structure instead.
  • fix typo in release upload and require all files to be present for successful release.

holtzman
holtzman approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@holtzman holtzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgreat jgreat force-pushed the jgreat/refactor-ci-cd-part4 branch from d621570 to 9bb5aa2 Compare November 6, 2024 21:02
@jgreat jgreat merged commit 9ca5f71 into main Nov 6, 2024
17 checks passed
@jgreat jgreat deleted the jgreat/refactor-ci-cd-part4 branch November 6, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtzman holtzman holtzman approved these changes

@joekottke joekottke Awaiting requested review from joekottke joekottke is a code owner

@nick-mobilecoin nick-mobilecoin Awaiting requested review from nick-mobilecoin nick-mobilecoin is a code owner

@starkriedesel starkriedesel Awaiting requested review from starkriedesel starkriedesel is a code owner

@sugargoat sugargoat Awaiting requested review from sugargoat sugargoat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgreat @holtzman