Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build tools #1021

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Update build tools #1021

merged 3 commits into from
Nov 19, 2024

Conversation

jgreat
Copy link
Contributor

@jgreat jgreat commented Nov 19, 2024

Motivation

  • update mob prompt to use mobilecoin/fat-builder image.
  • refactor scrips in tools/ for consistency and pass shellcheck

joekottke
joekottke approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@joekottke joekottke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up

@jgreat jgreat merged commit 7a5c094 into main Nov 19, 2024
24 checks passed
@jgreat jgreat deleted the jgreat/fat-builder branch November 19, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joekottke joekottke joekottke approved these changes

@holtzman holtzman Awaiting requested review from holtzman holtzman is a code owner

@nick-mobilecoin nick-mobilecoin Awaiting requested review from nick-mobilecoin nick-mobilecoin is a code owner

@starkriedesel starkriedesel Awaiting requested review from starkriedesel starkriedesel is a code owner

@sugargoat sugargoat Awaiting requested review from sugargoat sugargoat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgreat @joekottke