Fail transaction logs when input txos are consumed #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-mobilecoin
requested review from
holtzman,
jgreat,
joekottke,
starkriedesel and
sugargoat
as code owners
nick-mobilecoin
commented
Dec 3, 2024
nick-mobilecoin
commented
Dec 3, 2024
nick-mobilecoin
commented
Dec 3, 2024
Base automatically changed from
nick/fix-transaction-logs-incorrectly-marked-successful
to
main
December 3, 2024 22:22
Previously a transaction log would need to wait for the tombstone block to occur. Now when an input txo is spent any transaction logs that haven't been finalized and use that input txo will be marked failed.
nick-mobilecoin
force-pushed
the
nick/fail-transaction-logs-with-consumed-inputs
branch
from
64b37a5 to
7cf90f2
Compare
holtzman
reviewed
Dec 3, 2024
nick-mobilecoin
deleted the
nick/fail-transaction-logs-with-consumed-inputs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a transaction log would need to wait for the tombstone block
to occur. Now when an input txo is spent any transaction logs that
haven't been finalized and use that input txo will be marked failed.