Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uprev mobilecoin and deal with new Rust version fallbacks #136

Merged
merged 7 commits into from
May 4, 2021

Conversation

eranrund
Copy link
Contributor

@eranrund eranrund commented May 4, 2021

The mobilecoin repository has moved to a newer Rust toolchain, and as a result a bunch of small stuff had to be fixed. This PR uprevs mobilecoin and fixes the small issues.

Copy link
Contributor

@christian-oudard christian-oudard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look like good updates. Approved. As soon as unittests are fixed it'll be ready to merge.

@eranrund eranrund merged commit 6916c0c into develop May 4, 2021
@eranrund eranrund deleted the new-rust branch May 4, 2021 23:08
christian-oudard pushed a commit that referenced this pull request May 4, 2021
* get future clippy happy, some mobilecoin uprev fixes

* new rust fixes and uprev

* update rustfmt

* Ensure rebase didnt mess anything

* fix hardcoded fee

* another test fix

* test fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants