can now claim gift codes to fog enabled addresses

[briancorbin]

No description provided.

[eranrund]

I think this can be simplified to something like this since there is only a single address here:

let fog_resolver = {
    // This should convert the Option<String> into Option<Result<FogUri, Err>> and then transpose will convert to Result<Option<FogUri>, Err>. The ? operator will then return the error if there is one, and if not fog_uri will be Option<FogUri>
    let fog_uri = recipient_public_address.fog_report_url().map(FogUri::from_str).transpose().map_err(GiftCodeServiceError::InvaligFogUri)?;

    let uri_slice = if let Some(uri) = fog_uri {
        &[uri]
    } else {
        &[]
    };

    (self.fog_resolver_factory)(uri_slice).map_err(GiftCodeServiceError::FogPubkeyResolver)?;
}

You'll need to add error types to GiftCodeServiceError. UnexpectedTxStatus is not suitable for this.

[eranrund]

Actually maybe this isn't any better, but the comment on the error variant is still relevant.
I believe core::slice::from_ref(&x) can be replaced with &[&x].

[briancorbin]

ah, thanks for catching that, meant to change that after getting it working!

[itdaniher]

YAY BRIAN!