Make logging of validator-related failures more explicit #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugargoat
approved these changes
Jan 25, 2022
wjuan-mob
reviewed
Jan 25, 2022
| @@ -57,6 +58,7 @@ impl ValidatorConnection { | |||
| uri: uri.clone(), | |||
| validator_api_client, | |||
| blockchain_api_client, | |||
| logger, | |||
There was a problem hiding this comment.
Would it make sense to add context to this logger so that it says that it's for the validator rather than adding "validator" to all the logged warnings/errors?
There was a problem hiding this comment.
In my experience the context is not great for immediately communicating information to users, since its usually the message that gets looked at and not the custom fields.
wjuan-mob
approved these changes
Jan 26, 2022
briancorbin
added a commit
that referenced
this pull request
Feb 9, 2022
* make validator failure logs more verbose to ease debugging (#239) * Fix a bug in receipt status endpoint. (#233) * Uprev MobileCoin Library (#242) * Update TXO documentation (#241) * Update builder and base image references (#244) * Feature/sync performance (#245) * change tombstone block default to 10 (#246) * adding max limit to some API endpoints (#248)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I ran into this log message today:
Initially it appeared to me as if
fog.prod.mobilecoinww.comwas not responding, but in reality it was the validator node that was not responding. This confusion will make future debugging more difficult, so I am proposing to make some logging more verbose.In this PR