Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incomplete received tx_log response for v1 API #496

Merged
merged 6 commits into from
Oct 4, 2022
Merged

Fix incomplete received tx_log response for v1 API #496

merged 6 commits into from
Oct 4, 2022

Conversation

briancorbin
Copy link
Contributor

No description provided.

@briancorbin briancorbin requested a review from a team October 2, 2022 18:26
@briancorbin briancorbin changed the title Look up and provide public address b58 if available for v1 received transaction logs Fix incomplete received tx_log response for v1 API Oct 3, 2022
@briancorbin briancorbin linked an issue Oct 3, 2022 that may be closed by this pull request
v1 TxLog response for received Txos is incomplete #498
Closed
@briancorbin briancorbin added the bug Something isn't working label Oct 3, 2022
david1alvarez
david1alvarez reviewed Oct 3, 2022
View reviewed changes
Copy link
Contributor

@david1alvarez david1alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good, though it looks like some of the conditional flows are deeper than they need to be

full-service/src/json_rpc/v1/api/wallet.rs Outdated Show resolved Hide resolved
full-service/src/json_rpc/v1/api/wallet.rs Show resolved Hide resolved
david1alvarez
david1alvarez approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@david1alvarez david1alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@briancorbin briancorbin merged commit a70fe57 into develop Oct 4, 2022
@briancorbin briancorbin deleted the bugfix/received-tx-logs-all-orphaned branch October 4, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david1alvarez david1alvarez david1alvarez approved these changes

@Shramp Shramp Shramp approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1 TxLog response for received Txos is incomplete
3 participants
@briancorbin @Shramp @david1alvarez