Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions to consolidate duplicated code for building #510

Merged
merged 22 commits into from
Oct 12, 2022

Conversation

briancorbin
Copy link
Contributor

@briancorbin briancorbin commented Oct 7, 2022

Consolidating duplicated code
Changing the copied binaries for full-service to mc-full-service
Adjusting the release script to reflect these changes

@briancorbin briancorbin changed the title Brian/gha testin Update github actions to consolidate duplicated code for building Oct 10, 2022
@briancorbin briancorbin requested a review from a team October 10, 2022 18:44
@eranrund
Copy link
Contributor

I'm looking at https://github.com/mobilecoinofficial/full-service/actions/runs/3207691446 (which is from the last run) and seeing this:
image

Shouldn't there be a mac arm artifact?

@briancorbin
Copy link
Contributor Author

I'm looking at https://github.com/mobilecoinofficial/full-service/actions/runs/3207691446 (which is from the last run) and seeing this: image

Shouldn't there be a mac arm artifact?

I'll run again to double check, but yes there should be

@briancorbin briancorbin requested a review from eranrund October 11, 2022 18:43
@eranrund
Copy link
Contributor

What happened to the build job?
Looks like this is now only testing one configuration?

@briancorbin
Copy link
Contributor Author

What happened to the build job? Looks like this is now only testing one configuration?

renamed it to build_and_pre_release

@eranrund
Copy link
Contributor

What happened to the build job? Looks like this is now only testing one configuration?

renamed it to build_and_pre_release

I'm only seeing these checks:
image

Previously this had:
image

@briancorbin
Copy link
Contributor Author

weird, idk, but it definitely ran https://github.com/mobilecoinofficial/full-service/actions/runs/3229524670

maybe something up with github?

@briancorbin
Copy link
Contributor Author

I'll just rerun it

@briancorbin
Copy link
Contributor Author

@eranrund checks showed up!

@briancorbin briancorbin merged commit 4a1d9e8 into develop Oct 12, 2022
@briancorbin briancorbin deleted the brian/gha-testin branch October 12, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants