drop txo field from txos table in db #534

pouneh · 2022-10-18T19:47:10Z

Resolves #431

… linux

…argo.toml

This reverts commit 4a057f9.

full-service/src/service/ledger.rs

…unwraps

…roposal instead of the transactin log when writing to the ledger

…tx_proposal instead of the transactin log when writing to the ledger

…index to use the tx_proposal instead of the transactin log when writing to the ledger

briancorbin

This looks great!

full-service/src/test_utils.rs

…e_in_db

pouneh added 16 commits October 17, 2022 12:15

Turn code line into code block

afbc7e5

Explicitly gitignore the sgx libraries downloaded when developing for…

d61f99f

… linux

First draft of migration

7df9ac7

Update README diesel hash to match the one we depend on formally in C…

f2fcf0d

…argo.toml

Probably don't need the down path

4a057f9

DOCS: update upgrade scenario notes

796c4bc

Revert "Probably don't need the down path"

d3b189b

This reverts commit 4a057f9.

DOCS: update diesel migration instructions

d526755

WIP: Remove TXO from schema.rs

0f2922f

WIP: remove txo field from db related structs

aad0685

DOCS: update readme

ce757ff

WIP: Use the txo id to get the txo from the ledger service

1293dd5

WIP:get ledger.rs to get a txo from the txo id

c8da0c0

WIP: use ledger to get the txo

2a40b69

Fix some unwrapping issues

c40e690

REFACTOR: inline variables

09b43d2

pouneh requested review from briancorbin and sugargoat October 18, 2022 19:47

pouneh marked this pull request as draft October 18, 2022 20:15

Fix compiler errors for tests

f3e9535

briancorbin reviewed Oct 19, 2022

View reviewed changes

full-service/src/service/ledger.rs Outdated Show resolved Hide resolved

pouneh added 9 commits October 20, 2022 10:53

Fix one test

c77e65e

Move get_tx_out_by_public_key to ledger.rs

cd64fae

Update helper function uses

a4fb223

Make get_tx_out_by_index return a result instead of using a bunch of …

2811897

…unwraps

Unwrap the txout from receipt

d9aee34

Remove uneeded function

e082b9c

Update db::transaction_log::tests::test_log_submitted to use the tx_p…

43e7c34

…roposal instead of the transactin log when writing to the ledger

Update service::transaction::tests::test_send_transaction to use the …

da2791f

…tx_proposal instead of the transactin log when writing to the ledger

oops: make sure we get the input_txos from the proposal

1c6ad09

pouneh added 10 commits October 20, 2022 16:34

Update test_list_transaction_logs_for_account_with_min_and_max_block_…

40aae23

…index to use the tx_proposal instead of the transactin log when writing to the ledger

Remove unused import

463f069

fix typos

8e1e4a3

Don't need to decode the keyimage

2ce7e95

refactor: rename

9044fab

Change signature

1f19758

Remove because our db no loner has the actual txos in it

478d604

remove unused var

0e248e9

Finish fixing tests

5d7df6d

cargo fmt

709339d

pouneh marked this pull request as ready for review October 21, 2022 01:24

pouneh requested a review from briancorbin October 21, 2022 01:24

briancorbin suggested changes Oct 21, 2022

View reviewed changes

full-service/src/test_utils.rs Outdated Show resolved Hide resolved

full-service/src/test_utils.rs Outdated Show resolved Hide resolved

pouneh added 4 commits October 21, 2022 08:41

Remove transaction_log version of the create_test_minted_and_change_txos

1e7ed64

Remove tx_proposal version of the create_test_minted_and_change_txos

9a72b69

Remove unused test helper

ca09433

reformat: rustfmt

8c6d789

pouneh requested a review from briancorbin October 21, 2022 16:08

Merge branch 'develop' into pouneh/#431_drop_txo_field_from_txos_tabl…

91ece70

…e_in_db

briancorbin approved these changes Oct 25, 2022

View reviewed changes

Merge branch 'develop' into pouneh/#431_drop_txo_field_from_txos_tabl…

0b3aabc

…e_in_db

cxloe self-requested a review October 26, 2022 20:25

cxloe approved these changes Oct 26, 2022

View reviewed changes

pouneh merged commit 489fc50 into develop Oct 27, 2022

pouneh deleted the pouneh/#431_drop_txo_field_from_txos_table_in_db branch October 27, 2022 01:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drop txo field from txos table in db #534

drop txo field from txos table in db #534

pouneh commented Oct 18, 2022

briancorbin left a comment

drop txo field from txos table in db #534

drop txo field from txos table in db #534

Conversation

pouneh commented Oct 18, 2022

briancorbin left a comment

Choose a reason for hiding this comment