Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage measurements to test script #535

Merged
merged 7 commits into from
Oct 26, 2022
Merged

Add code coverage measurements to test script #535

merged 7 commits into from
Oct 26, 2022

Conversation

brucek
Copy link
Contributor

@brucek brucek commented Oct 20, 2022

Soundtrack of this PR: link to song that really fits the mood of this PR

Motivation

Adding test coverage metrics

In this PR

  • Updated the test.sh script and related docs

Future Work

@brucek brucek requested review from briancorbin and pouneh October 20, 2022 01:00
@eranrund
Copy link
Contributor

eranrund commented Oct 20, 2022 •
edited
Loading

Might want to consider https://about.codecov.io/
The SGX repository is using it and can be used as a reference: https://github.com/mobilecoinfoundation/sgx/blob/main/.github/workflows/build.yaml#L220

@briancorbin
Copy link
Contributor

Might want to consider https://about.codecov.io/ The SGX repository is using it and can be used as a reference: https://github.com/mobilecoinfoundation/sgx/blob/main/.github/workflows/build.yaml#L220

Oh that's awesome, thanks for sharing that

briancorbin
briancorbin suggested changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@briancorbin briancorbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, could we add the codecov.io to this before we merge it?

@briancorbin briancorbin mentioned this pull request Oct 22, 2022
Merged
@briancorbin briancorbin self-requested a review October 26, 2022 18:19
@briancorbin briancorbin merged commit 1f32c01 into develop Oct 26, 2022
@briancorbin briancorbin deleted the test-coverage branch October 26, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pouneh pouneh pouneh approved these changes

@briancorbin briancorbin briancorbin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brucek @eranrund @briancorbin @pouneh