Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed to provide default values when offline #556

Merged
merged 4 commits into from
Nov 4, 2022

Conversation

briancorbin
Copy link
Contributor

Previously this would error with "NoLastBlockInfo", which was technically correct but not the function we actually want it to do when in offline mode. Now, if it's in offline mode it will respond with default values defined in the mobilecoin library

@briancorbin briancorbin requested review from a team and eranrund November 2, 2022 23:41
@briancorbin
Copy link
Contributor Author

@eranrund Do you have a suggestion for dealing with eUSD? It doesn't seem to be defined the same as Mob in the mc library. Should we add an implementation for it's default to the mc lib?

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@c21ae76). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #556   +/-   ##
==========================================
  Coverage           ?   59.05%           
==========================================
  Files              ?       82           
  Lines              ?    11302           
  Branches           ?     1829           
==========================================
  Hits               ?     6674           
  Misses             ?     3110           
  Partials           ?     1518           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@briancorbin briancorbin linked an issue Nov 3, 2022 that may be closed by this pull request
Copy link
Contributor

@Shramp Shramp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@briancorbin briancorbin merged commit ffbc40a into develop Nov 4, 2022
@briancorbin briancorbin deleted the bugfix/network-status-error-when-offline branch November 4, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_wallet_status returns an error when FS is run in offline mode
4 participants