Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov yaml file, and explicitly tell it to look at our develop branch as its default #585

Merged
merged 4 commits into from
Nov 21, 2022

Conversation

pouneh
Copy link
Contributor

@pouneh pouneh commented Nov 16, 2022

Codecov is broken for our repo. This is the first thing I found that could be fixed.

Code coverage acts as a simple measure of how effective our tests are. We can use it to identify areas that we could use more confidence in, and make tests to help build confidence and drive quality

@pouneh pouneh requested a review from brucek November 16, 2022 22:36
codecov.yml Show resolved Hide resolved
@pouneh pouneh requested a review from brucek November 17, 2022 17:21
@pouneh pouneh changed the title Pouneh/codecov/183810596 Fix codecov yaml file, and explicitly tell it to look at our develop branch as its default Nov 17, 2022
codecov.yml Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@aba457a). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #585   +/-   ##
==========================================
  Coverage           ?   59.27%           
==========================================
  Files              ?       82           
  Lines              ?    11496           
  Branches           ?     1852           
==========================================
  Hits               ?     6814           
  Misses             ?     3149           
  Partials           ?     1533           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pouneh pouneh merged commit a5d0684 into develop Nov 21, 2022
@pouneh pouneh deleted the pouneh/codecov/183810596 branch November 21, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants