Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test config as cmdline param #599

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

pouneh
Copy link
Contributor

@pouneh pouneh commented Nov 24, 2022

allow the test caller to specify a different config file

@pouneh pouneh force-pushed the pouneh/integ-test/config-commandline-arg branch from 8c6b3d7 to 7c8f15c Compare November 24, 2022 17:33
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@14c6e14). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #599   +/-   ##
==========================================
  Coverage           ?   59.25%           
==========================================
  Files              ?       82           
  Lines              ?    11499           
  Branches           ?     1859           
==========================================
  Hits               ?     6814           
  Misses             ?     3152           
  Partials           ?     1533           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

integ-tests/basic.py Outdated Show resolved Hide resolved
@pouneh pouneh marked this pull request as ready for review November 28, 2022 23:32
@pouneh pouneh changed the title cmdline param test config as cmdline param Nov 28, 2022
Copy link
Contributor

@jgreat jgreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just working on something like this, you beat me to it. LGTM

@pouneh pouneh merged commit 4ae8ffd into develop Nov 29, 2022
@pouneh pouneh deleted the pouneh/integ-test/config-commandline-arg branch November 29, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants