Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove soundtrack from PR and add test section #604

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Remove soundtrack from PR and add test section #604

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bebae30
Remove soundtrack from PR and add test section
pouneh Nov 24, 2022
ea0c7a5
Merge branch 'develop' into pouneh/pr-template
pouneh Nov 29, 2022
f9dc233
Merge branch 'develop' into pouneh/pr-template
pouneh Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
Soundtrack of this PR: [link to song that really fits the mood of this PR]()

### Motivation

< The motivation for the changes in this PR. "Currently we...", "This is needed because..." >
Expand All @@ -9,6 +7,12 @@ Soundtrack of this PR: [link to song that really fits the mood of this PR]()

< Ticket status, e.g. "fixes #issue number" >

### Test Plan

< How to run the unit test, e2e test etc. >
< Or what are the actual request/response might look like (like grpcurl) >


### Future Work
* < Out of scope non-goals for this PR >
* < These should be links to tickets. If the tickets do not exist, make them. >
Expand Down