-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move basic.py to where ci-cd will pick it up from #610
Conversation
…he cli dir anymore
…ficial/full-service into pouneh/integ-test/183925740
aed17df
to
f2c540f
Compare
maybe this should be a symlink instead. we could have the integ-tests folder in python-library, then symlink it to the CI dir. i wonder if this approach would work? |
Codecov ReportBase: 59.28% // Head: 59.29% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #610 +/- ##
========================================
Coverage 59.28% 59.29%
========================================
Files 82 82
Lines 11503 11503
Branches 1858 1858
========================================
+ Hits 6820 6821 +1
Misses 3149 3149
+ Partials 1534 1533 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2 Q's for you here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good catch on the docs, not sure how I forgot to put the poetry install
step in the README.
|
mm I'm not sure how to do the symlinking in a good way .. like who creates the symlink/maintains it? |
I think having the integration tests in the For ease of use and only having to maintain a single set of dependencies, we can have multiple scripts/tests in this Also breaking it up into other directories or renaming it under the I kinda think that if we want tests that are integrated with the main repo structure, we should probably write them as rust utilities. |
a symlink is just a file that points to another file.. there's not anything to maintain? |
e4bf33c
to
73b67a6
Compare
Do people have to set up that symlink manually on their machine, if not we're checking it in? Can we even checkin a symlink? If we do, will we hit snags when people clone this across different machines? There's just too many questions I don't know how to answer .. and I think fidling til I find out the answer isn't ... really what I want to do with this PR :( |
…ficial/full-service into pouneh/integ-test/183925740
You can check in a symlink. It should work as long as it's not pointing all the way from a machine specific dir.. so you'd just want to move back a few directories instead of doing something like |
Motivation
We want to ensure we do quality checks on ci by running integration tests
In this PR
The ci-cd pipeline currently uses a sparse test. Moving the most up-to-date integ test to where ci reads the tests it uses.
Addresses PT#183925740
Test Plan
You can run this test by navigating to the directory and running
poetry run python3 basic.py
Mostly, testing this change is seeing the test run successfully on CI as part of this PR