Feature/track build signed submitted for tx log #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this logging be configurable / disableable? And why the change of |
cxloe
approved these changes
Dec 7, 2022
briancorbin
deleted the
feature/track-build-signed-submitted-for-tx-log
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, we haven't been tracking transactions that were built but not signed. In order to support view only accounts with the offline signer and hardware wallet better, this adds that so we can track which inputs and outputs are for the built, but unsigned, transaction.
In this PR
tombstone_block_indexwasn't updated correctly if transaction log exists when submittingFuture Work
Continued changes to support hardware wallet and offline transaction signing
Moving TransactionId, TxoId, and AccountId to the mobilecoin library to provide a central source of truth for these