Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore command line --version flag #657

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Conversation

holtzman
Copy link
Collaborator

Motivation

Version 2.1.2 of full-service switched from using the structopt crate to the clap crate for command line parsing and as a result full-service --version stopped working. This PR returns the --version command line flag.

In this PR

full-service --version will return the version number and exit, as it used to, prior to v2.1.2.

@codecov-commenter
Copy link

Codecov Report

Base: 60.14% // Head: 60.14% // No change to project coverage 👍

Coverage data is based on head (6051e55) compared to base (d961d5b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #657   +/-   ##
========================================
  Coverage    60.14%   60.14%           
========================================
  Files           85       85           
  Lines        11999    11999           
  Branches      1957     1957           
========================================
  Hits          7217     7217           
  Misses        3133     3133           
  Partials      1649     1649           
Impacted Files Coverage Δ
full-service/src/config.rs 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@holtzman holtzman merged commit 5b4b955 into develop Jan 24, 2023
@holtzman holtzman deleted the bugfix/cli-version-flag branch January 24, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants