-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/input txos too large #660
Conversation
Codecov ReportBase: 59.99% // Head: 60.33% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #660 +/- ##
===========================================
+ Coverage 59.99% 60.33% +0.33%
===========================================
Files 85 85
Lines 12037 12168 +131
Branches 1967 1986 +19
===========================================
+ Hits 7222 7341 +119
+ Misses 3159 3153 -6
- Partials 1656 1674 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks for iterating on this. I have some suggestions on stricter tests.
This reverts commit b939328.
2529272
to
20852f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some pending comments. Thank you!
Fixes a bug where inputs were being restricted to < u64 max total, which is not necessary. Also fixes several bugs related to u64 conversions and generation of change txos.
Todo