Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/input txos too large #660

Merged
merged 14 commits into from
Jan 25, 2023
Merged

Conversation

briancorbin
Copy link
Contributor

@briancorbin briancorbin commented Jan 12, 2023

Fixes a bug where inputs were being restricted to < u64 max total, which is not necessary. Also fixes several bugs related to u64 conversions and generation of change txos.

Todo

  • Currently we only support change txos that are of size u64::MAX or less. Unsure if we should create as many as necessary, or force users to be explicit about their transaction inputs/outputs if the auto builder cant pick them normally

@briancorbin briancorbin requested review from eranrund and a team January 12, 2023 18:23
@briancorbin briancorbin marked this pull request as ready for review January 24, 2023 06:24
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023

Codecov Report

Base: 59.99% // Head: 60.33% // Increases project coverage by +0.33% 🎉

Coverage data is based on head (94b6893) compared to base (ab854ee).
Patch coverage: 83.23% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #660      +/-   ##
===========================================
+ Coverage    59.99%   60.33%   +0.33%     
===========================================
  Files           85       85              
  Lines        12037    12168     +131     
  Branches      1967     1986      +19     
===========================================
+ Hits          7222     7341     +119     
+ Misses        3159     3153       -6     
- Partials      1656     1674      +18     
Impacted Files Coverage Δ
full-service/src/error.rs 5.69% <50.00%> (+0.46%) ⬆️
full-service/src/service/transaction_builder.rs 75.03% <81.60%> (+2.41%) ⬆️
full-service/src/db/txo.rs 77.29% <89.13%> (+0.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@eranrund eranrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for iterating on this. I have some suggestions on stricter tests.

full-service/src/db/txo.rs Outdated Show resolved Hide resolved
full-service/src/db/txo.rs Outdated Show resolved Hide resolved
full-service/src/db/txo.rs Outdated Show resolved Hide resolved
full-service/src/service/transaction_builder.rs Outdated Show resolved Hide resolved
@briancorbin briancorbin force-pushed the hotfix/input-txos-too-large branch from 2529272 to 20852f5 Compare January 25, 2023 02:04
@briancorbin briancorbin requested a review from eranrund January 25, 2023 02:09
@briancorbin briancorbin requested a review from eranrund January 25, 2023 03:31
Copy link
Contributor

@eranrund eranrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some pending comments. Thank you!

full-service/src/service/transaction_builder.rs Outdated Show resolved Hide resolved
full-service/src/service/transaction_builder.rs Outdated Show resolved Hide resolved
full-service/src/service/transaction_builder.rs Outdated Show resolved Hide resolved
@briancorbin briancorbin merged commit 7d577cb into develop Jan 25, 2023
@briancorbin briancorbin deleted the hotfix/input-txos-too-large branch January 25, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants