Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resurrect full-service command-line interface. #673

Merged
merged 9 commits into from
Jan 25, 2023

Conversation

christian-oudard
Copy link
Contributor

Add an --offline option to run-fs.sh.
Resurrect full-service command-line interface.

Remove run-fs-offline.sh, which does not actually run offline.
Rename executable from "mobcli" to "mob".
Rename the builder docker image to "mob-builder"
Move the mc_util library to the "mobilecoin" namespace.
@christian-oudard christian-oudard changed the title feature/resurrect cli Resurrect full-service command-line interface. Jan 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

Base: 59.99% // Head: 60.02% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (bc9c798) compared to base (8258587).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #673      +/-   ##
===========================================
+ Coverage    59.99%   60.02%   +0.02%     
===========================================
  Files           85       85              
  Lines        12037    12037              
  Branches      1967     1967              
===========================================
+ Hits          7222     7225       +3     
+ Misses        3159     3155       -4     
- Partials      1656     1657       +1     
Impacted Files Coverage Δ
full-service/src/db/wallet_db.rs 23.48% <0.00%> (-0.76%) ⬇️
full-service/src/error.rs 7.32% <0.00%> (+2.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

python/bin/mob Show resolved Hide resolved
Copy link
Contributor

@briancorbin briancorbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than renaming mob-builder back to mob and the comment I left

python/pyproject.toml Outdated Show resolved Hide resolved
@briancorbin briancorbin added the enhancement New feature or request label Jan 24, 2023
@briancorbin briancorbin merged commit ab854ee into develop Jan 25, 2023
@briancorbin briancorbin deleted the feature/resurrect-cli branch January 25, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants