-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resurrect full-service command-line interface. #673
Conversation
Remove run-fs-offline.sh, which does not actually run offline.
Rename executable from "mobcli" to "mob". Rename the builder docker image to "mob-builder" Move the mc_util library to the "mobilecoin" namespace.
Codecov ReportBase: 59.99% // Head: 60.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #673 +/- ##
===========================================
+ Coverage 59.99% 60.02% +0.02%
===========================================
Files 85 85
Lines 12037 12037
Branches 1967 1967
===========================================
+ Hits 7222 7225 +3
+ Misses 3159 3155 -4
- Partials 1656 1657 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, other than renaming mob-builder back to mob and the comment I left
Add an --offline option to run-fs.sh.
Resurrect full-service command-line interface.