Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script improvements #702

Merged
merged 8 commits into from
Feb 10, 2023
Merged

Script improvements #702

merged 8 commits into from
Feb 10, 2023

Conversation

pouneh
Copy link
Contributor

@pouneh pouneh commented Feb 8, 2023

Motivation

Test.sh

  • Previously we just ran it, and it may fail part way through if a consensus sigstruct doesn't exist in the full-service root directory. This is an issue mostly on a fresh clone of the repository. This change just makes the script fail earlier if it would fail on a missing sigstruct file anyway.

Build.sh

  • The sigstruct gets build as part of building the mobilecoin submodule, and should therefore be grabbed from its target directory.

Run.sh

  • Unfortunately, the localhost/port# way of getting the ledger-distribution data isn't working the way it used to when running full-service against a local-network in a different container. We just grab the file directly.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 60.19% // Head: 60.18% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (aaf8515) compared to base (20eabc8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #702      +/-   ##
===========================================
- Coverage    60.19%   60.18%   -0.01%     
===========================================
  Files           87       87              
  Lines        12277    12277              
  Branches      1989     1989              
===========================================
- Hits          7390     7389       -1     
  Misses        3207     3207              
- Partials      1680     1681       +1     
Impacted Files Coverage Δ
full-service/src/db/wallet_db.rs 23.48% <0.00%> (-0.76%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pouneh pouneh marked this pull request as ready for review February 8, 2023 20:47
tools/run-fs.sh Outdated Show resolved Hide resolved
tools/test.sh Outdated Show resolved Hide resolved
@pouneh pouneh requested a review from briancorbin as a code owner February 9, 2023 01:05
@pouneh pouneh merged commit c51b7de into develop Feb 10, 2023
@pouneh pouneh deleted the bugfix/script_improvements branch February 10, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants