Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding redacted for sensitive information in logs v2 API #908

Merged
merged 5 commits into from
Nov 11, 2023

Conversation

briancorbin
Copy link
Contributor

Improving the security of our logging setup by redacting specified sensitive fields from appearing in logs

@docs-page
Copy link

docs-page bot commented Aug 18, 2023

To view this pull requests documentation preview, visit the following URL:

docs.page/mobilecoinofficial/full-service~908

Documentation is deployed and generated using docs.page.

Copy link
Contributor

@remoun remoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

full-service/src/json_rpc/v1/api/wallet.rs Show resolved Hide resolved
Copy link

@starkriedesel starkriedesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this!

@codecov-commenter
Copy link

Codecov Report

Attention: 390 lines in your changes are missing coverage. Please review.

Comparison is base (ab2af32) 60.12% compared to head (9d42b0e) 54.87%.
Report is 152 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
- Coverage   60.12%   54.87%   -5.25%     
==========================================
  Files          88      124      +36     
  Lines       12356    15741    +3385     
  Branches     2010     2717     +707     
==========================================
+ Hits         7429     8638    +1209     
- Misses       3238     5105    +1867     
- Partials     1689     1998     +309     
Files Coverage Δ
full-service/src/db/gift_code.rs 67.85% <100.00%> (+1.19%) ⬆️
full-service/src/db/txo.rs 79.31% <ø> (+2.57%) ⬆️
full-service/src/json_rpc/v1/api/request.rs 76.98% <100.00%> (-1.59%) ⬇️
...service/src/json_rpc/v1/models/receiver_receipt.rs 77.77% <ø> (+0.99%) ⬆️
full-service/src/json_rpc/v1/models/tx_proposal.rs 73.86% <100.00%> (+0.60%) ⬆️
full-service/src/json_rpc/v1/models/txo.rs 59.48% <100.00%> (+4.93%) ⬆️
full-service/src/json_rpc/v2/api/test_utils.rs 84.70% <100.00%> (+0.09%) ⬆️
...-service/src/json_rpc/v2/models/account_secrets.rs 35.29% <ø> (+0.60%) ⬆️
full-service/src/json_rpc/v2/models/amount.rs 65.00% <ø> (ø)
full-service/src/json_rpc/v2/models/balance.rs 55.00% <ø> (+2.61%) ⬆️
... and 57 more

... and 45 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briancorbin briancorbin merged commit 045f4d4 into main Nov 11, 2023
7 of 8 checks passed
@briancorbin briancorbin deleted the feature/redact-sensitive-logs branch November 11, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants