Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix validate_sender_memo to support authenticated sender memos with payment ids #945

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

eranrund
Copy link
Contributor

@eranrund eranrund commented Jan 9, 2024

No description provided.

Copy link

docs-page bot commented Jan 9, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/mobilecoinofficial/full-service~945

Documentation is deployed and generated using docs.page.

@codecov-commenter
Copy link

Codecov Report

Attention: 408 lines in your changes are missing coverage. Please review.

Comparison is base (ab2af32) 60.12% compared to head (4edc099) 54.74%.
Report is 165 commits behind head on main.

Files Patch % Lines
full-service/src/json_rpc/v2/api/wallet.rs 21.54% 103 Missing and 39 partials ⚠️
full-service/src/json_rpc/v1/api/wallet.rs 37.50% 30 Missing and 15 partials ⚠️
full-service/src/db/transaction_log.rs 70.92% 0 Missing and 41 partials ⚠️
full-service/src/db/account.rs 81.08% 16 Missing and 12 partials ⚠️
full-service/src/error.rs 0.00% 23 Missing ⚠️
full-service/src/db/schema.rs 39.28% 1 Missing and 16 partials ⚠️
full-service/src/db/wallet_db_error.rs 0.00% 17 Missing ⚠️
full-service/src/db/models.rs 20.00% 11 Missing and 5 partials ⚠️
full-service/src/db/wallet_db.rs 21.05% 15 Missing ⚠️
...-service/src/json_rpc/v1/models/transaction_log.rs 63.63% 2 Missing and 10 partials ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
- Coverage   60.12%   54.74%   -5.38%     
==========================================
  Files          88      124      +36     
  Lines       12356    15873    +3517     
  Branches     2010     2749     +739     
==========================================
+ Hits         7429     8690    +1261     
- Misses       3238     5156    +1918     
- Partials     1689     2027     +338     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@holtzman holtzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eranrund eranrund merged commit c3d3fcb into main Jan 10, 2024
3 checks passed
@eranrund eranrund deleted the validate-payment-memos branch January 10, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants