Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to integration tests #948

Merged
merged 2 commits into from
Jan 18, 2024
Merged

fixes to integration tests #948

merged 2 commits into from
Jan 18, 2024

Conversation

holtzman
Copy link
Collaborator

Motivation

3 of the integration tests full-service were always failing because of issues with the test or testing fixtures

In this PR

  • Updatecreate_fog account creating fixture to pass fog information in the format that import_account expects.
  • Update the account_status test to include managed_by_hardware_wallet in the list of expected account status keys.

Copy link

docs-page bot commented Jan 18, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/mobilecoinofficial/full-service~948

Documentation is deployed and generated using docs.page.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 408 lines in your changes are missing coverage. Please review.

Comparison is base (ab2af32) 60.12% compared to head (d8103e3) 54.74%.
Report is 168 commits behind head on main.

Files Patch % Lines
full-service/src/json_rpc/v2/api/wallet.rs 21.54% 103 Missing and 39 partials ⚠️
full-service/src/json_rpc/v1/api/wallet.rs 37.50% 30 Missing and 15 partials ⚠️
full-service/src/db/transaction_log.rs 70.92% 0 Missing and 41 partials ⚠️
full-service/src/db/account.rs 81.08% 16 Missing and 12 partials ⚠️
full-service/src/error.rs 0.00% 23 Missing ⚠️
full-service/src/db/schema.rs 39.28% 1 Missing and 16 partials ⚠️
full-service/src/db/wallet_db_error.rs 0.00% 17 Missing ⚠️
full-service/src/db/models.rs 20.00% 11 Missing and 5 partials ⚠️
full-service/src/db/wallet_db.rs 21.05% 15 Missing ⚠️
...-service/src/json_rpc/v1/models/transaction_log.rs 63.63% 2 Missing and 10 partials ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
- Coverage   60.12%   54.74%   -5.38%     
==========================================
  Files          88      124      +36     
  Lines       12356    15873    +3517     
  Branches     2010     2748     +738     
==========================================
+ Hits         7429     8690    +1261     
- Misses       3238     5156    +1918     
- Partials     1689     2027     +338     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtzman holtzman merged commit 14ea142 into main Jan 18, 2024
3 checks passed
@holtzman holtzman deleted the fix-integration-tests branch January 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants