Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCAP Attestation for Full-Service #950

Merged
merged 10 commits into from
Jan 29, 2024
Merged

DCAP Attestation for Full-Service #950

merged 10 commits into from
Jan 29, 2024

Conversation

dolanbernard
Copy link
Contributor

Motivation

This PR updates full-service to support DCAP attestation. This will be needed for MobileCoin 6.0 support. EPID attestation is still supported during the transition period from 5.0 to 6.0.

In this PR

  • Update MobileCoin to 6.0
  • Switch from verifier to trusted identity API
  • Update patches and dependencies
  • Updated Rust toolchain

Copy link
Contributor

@nick-mobilecoin nick-mobilecoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, just needs some cargo fmt and probably a few CI updates for the rust version

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 416 lines in your changes are missing coverage. Please review.

Comparison is base (ab2af32) 60.12% compared to head (e026995) 54.82%.
Report is 170 commits behind head on main.

Files Patch % Lines
full-service/src/json_rpc/v2/api/wallet.rs 21.54% 103 Missing and 39 partials ⚠️
full-service/src/json_rpc/v1/api/wallet.rs 37.50% 30 Missing and 15 partials ⚠️
full-service/src/db/transaction_log.rs 70.92% 0 Missing and 41 partials ⚠️
full-service/src/db/account.rs 81.08% 16 Missing and 12 partials ⚠️
full-service/src/error.rs 0.00% 23 Missing ⚠️
full-service/src/db/schema.rs 39.28% 1 Missing and 16 partials ⚠️
full-service/src/db/wallet_db_error.rs 0.00% 17 Missing ⚠️
full-service/src/config.rs 20.00% 15 Missing and 1 partial ⚠️
full-service/src/db/wallet_db.rs 21.05% 15 Missing ⚠️
full-service/src/db/models.rs 30.00% 11 Missing and 3 partials ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #950      +/-   ##
==========================================
- Coverage   60.12%   54.82%   -5.31%     
==========================================
  Files          88      124      +36     
  Lines       12356    15831    +3475     
  Branches     2010     2742     +732     
==========================================
+ Hits         7429     8679    +1250     
- Misses       3238     5124    +1886     
- Partials     1689     2028     +339     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolanbernard dolanbernard merged commit 9bfcd57 into main Jan 29, 2024
3 checks passed
@dolanbernard dolanbernard deleted the bernie/dcap branch January 29, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants