Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uprev mobilecoin and ledger-mob submodules to mobilecoin v6 #952

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

holtzman
Copy link
Collaborator

Motivation

Working to prepare a version of full-service that is compatible with both MobileCoin core v5 and MobileCoin core v6 so full-service users can update in advance of the MobileCoin core v6 deployment. MobileCoin core v6 will be a breaking change as SGX attestation is switched from EPID to DCAP.

In this PR

Update the commits for the mobilecoin and ledger-mob submodules to be pinned to the MobileCoin core v6 release branch.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: 416 lines in your changes are missing coverage. Please review.

Comparison is base (ab2af32) 60.12% compared to head (642bf42) 54.82%.
Report is 172 commits behind head on main.

Files Patch % Lines
full-service/src/json_rpc/v2/api/wallet.rs 21.54% 103 Missing and 39 partials ⚠️
full-service/src/json_rpc/v1/api/wallet.rs 37.50% 30 Missing and 15 partials ⚠️
full-service/src/db/transaction_log.rs 70.92% 0 Missing and 41 partials ⚠️
full-service/src/db/account.rs 81.08% 16 Missing and 12 partials ⚠️
full-service/src/error.rs 0.00% 23 Missing ⚠️
full-service/src/db/schema.rs 39.28% 1 Missing and 16 partials ⚠️
full-service/src/db/wallet_db_error.rs 0.00% 17 Missing ⚠️
full-service/src/config.rs 20.00% 15 Missing and 1 partial ⚠️
full-service/src/db/wallet_db.rs 21.05% 15 Missing ⚠️
full-service/src/db/models.rs 30.00% 11 Missing and 3 partials ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
- Coverage   60.12%   54.82%   -5.31%     
==========================================
  Files          88      124      +36     
  Lines       12356    15831    +3475     
  Branches     2010     2741     +731     
==========================================
+ Hits         7429     8679    +1250     
- Misses       3238     5124    +1886     
- Partials     1689     2028     +339     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtzman holtzman merged commit ffd6d0a into main Feb 4, 2024
3 checks passed
@holtzman holtzman deleted the bump-to-mc-v6.0 branch February 4, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants