Remove command substitution in help message #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was a command substitution '`cargo check`' in the help message for `tools/build-fs.sh`. This resulted in `cargo check` being executed when the help message was printed. Now single quotes are used around the 'cargo check' text to separate it from the rest of the text in the help message.
nick-mobilecoin
requested review from
briancorbin,
eranrund,
christian-oudard and
holtzman
as code owners
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
eranrund
approved these changes
Jan 31, 2024
nick-mobilecoin
deleted the
nick/remove-command-substituion-in-help-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a command substitution '
cargo check' in the helpmessage for
tools/build-fs.sh. This resulted incargo checkbeingexecuted when the help message was printed. Now single quotes are used
around the 'cargo check' text to separate it from the rest of the text
in the help message.