Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test_network_status_fees to work on mainnet and testnet #962

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

holtzman
Copy link
Collaborator

Motivation

python integration tests fails API v2 test_network_status_fees on mainnet because mainnet lacks FauxUSD token.

In this PR

  • update test_network_status_fees to not require fees be set for FauxUSD

@codecov-commenter
Copy link

Codecov Report

Attention: 419 lines in your changes are missing coverage. Please review.

Comparison is base (ab2af32) 60.12% compared to head (c0fec72) 54.82%.
Report is 178 commits behind head on main.

Files Patch % Lines
full-service/src/json_rpc/v2/api/wallet.rs 24.73% 103 Missing and 40 partials ⚠️
full-service/src/json_rpc/v1/api/wallet.rs 37.50% 30 Missing and 15 partials ⚠️
full-service/src/db/transaction_log.rs 70.92% 0 Missing and 41 partials ⚠️
full-service/src/db/account.rs 81.08% 16 Missing and 12 partials ⚠️
full-service/src/error.rs 0.00% 23 Missing ⚠️
full-service/src/db/schema.rs 39.28% 1 Missing and 16 partials ⚠️
full-service/src/db/wallet_db_error.rs 0.00% 17 Missing ⚠️
full-service/src/config.rs 20.00% 15 Missing and 1 partial ⚠️
full-service/src/db/wallet_db.rs 21.05% 15 Missing ⚠️
full-service/src/db/models.rs 30.00% 11 Missing and 3 partials ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
- Coverage   60.12%   54.82%   -5.31%     
==========================================
  Files          88      124      +36     
  Lines       12356    15840    +3484     
  Branches     2010     2742     +732     
==========================================
+ Hits         7429     8684    +1255     
- Misses       3238     5126    +1888     
- Partials     1689     2030     +341     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtzman holtzman merged commit f006f4b into main Feb 13, 2024
3 checks passed
@holtzman holtzman deleted the fees-test branch February 13, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants