Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track change to mobilecoin release/v6.0 and OutlayV2 struct #965

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

holtzman
Copy link
Collaborator

Motivation

full-service should closely track the mobilecoin core v6.0 release work as there is need to release compatible full-service in advance of core v6.0 deployments due to breaking changes (DCAP attestation) that will prevent previous versions of full-service from working with core v6

In this PR

  • update mobilecoin.git submodule to latest release/v6.0 commits
  • update ledger-mob submodule to also incorporate latest release/v6.0 commits
  • update use of mc_mobilecoind::payments::OutlayV2 to specify new tx_private_key struct member

Copy link

docs-page bot commented Feb 21, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/mobilecoinofficial/full-service~965

Documentation is deployed and generated using docs.page.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab2af32) 60.12% compared to head (b346aed) 54.82%.
Report is 181 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   60.12%   54.82%   -5.30%     
==========================================
  Files          88      124      +36     
  Lines       12356    15841    +3485     
  Branches     2010     2742     +732     
==========================================
+ Hits         7429     8685    +1256     
- Misses       3238     5126    +1888     
- Partials     1689     2030     +341     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtzman holtzman merged commit 35ac984 into main Feb 23, 2024
3 checks passed
@holtzman holtzman deleted the chore/track-mobilecoin-v6-changes branch February 23, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants