Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for passing port of full-service via ENV #981

Merged
merged 2 commits into from
May 20, 2024
Merged

fix for passing port of full-service via ENV #981

merged 2 commits into from
May 20, 2024

Conversation

holtzman
Copy link
Collaborator

Motivation

Couldn't use mob cli with a full-service running on any port other than the default. Also, couldn't get mob cli to install without updating dependencies.

In this PR

  • bug fix so that env variable MC_FULL_SERVICE_PORT is now able to override DEFAULT_PORT as was intended
  • updated poetry.lock
  • also uprev'ed mob cli release while at it so that it can be packaged and released with this and any previous unreleased fixes.

@holtzman holtzman requested a review from nick-mobilecoin as a code owner May 19, 2024 22:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.58%. Comparing base (ab2af32) to head (d19da5d).
Report is 189 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
- Coverage   60.12%   55.58%   -4.55%     
==========================================
  Files          88      124      +36     
  Lines       12356    16227    +3871     
  Branches     2010     2787     +777     
==========================================
+ Hits         7429     9019    +1590     
- Misses       3238     5135    +1897     
- Partials     1689     2073     +384     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtzman holtzman merged commit 3ec9b66 into main May 20, 2024
3 checks passed
@holtzman holtzman deleted the fix/mob-cli branch May 20, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants