Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update python test client for require_spend_subaddress #994

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

holtzman
Copy link
Collaborator

@holtzman holtzman commented Jun 1, 2024

Motivation

python test client was throwing error on test_account_status test.

In this PR

  • updated python test client to be aware of new require_spend_subaddress key in get_account_status response.

Test Plan

poetry run test-client -v throws an error and indicates FAILED prior to this patch and indicates PASSED with patch applied.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.38%. Comparing base (ab2af32) to head (55e1299).
Report is 199 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
- Coverage   60.12%   55.38%   -4.75%     
==========================================
  Files          88      124      +36     
  Lines       12356    16354    +3998     
  Branches     2010     2815     +805     
==========================================
+ Hits         7429     9057    +1628     
- Misses       3238     5211    +1973     
- Partials     1689     2086     +397     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtzman holtzman merged commit 1eb2139 into main Jun 4, 2024
3 checks passed
@holtzman holtzman deleted the fix/python-test-client branch June 4, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants