-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mobilecoin core + ledger SDK for OS 1.1.2 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add Pending Review
Update to v0.15.0
update to v0.16.0 (fixes per functional review)
Remove pending review banner and disable pre-release feature.
Moving to new manifest format
Merge develop to main following B2CA-1341
use last Ledger Rust SDK published on crates.io
Merge branch develop into main
update nightly toolchain
Revert "update nightly toolchain"
Feat/update nightly
Only Nano S+ is currently supported
Add include_gif has a dependency (mandatory to manage properly Rust S…
holtzman
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
ryankurte
added a commit
that referenced
this pull request
Aug 12, 2024
* add Pending Review * rust.yml: update ci * Remove pending review banner and disable pre-release feature. * [clean] Moving to new manifest format * [auto]: add PR template * use last Ledger Rust SDK published on crates.io * update Rust SDK version * update API level for Nano S+ * update nightly toolchain * uprev dependencies for mobilecoin core v6 * update ci to rust nightly-2023-10-01 * Makefile fix * Bump SDK version * Revert "update nightly toolchain" * Only Nano S+ is currently supported * submodule latest mobilecoin release/v6.0 commit * [auto] Update screenshot * submodule mobilecoin.git branch for ledger-nano with v6.0.1 updates * Add include_gif has a dependency (mandatory to manage properly Rust SDK update) * uprev mobilecoin to v6.0.2 + serialization for TxoUnsync.subaddress * first pass of updating sdk versions * add block version 4 test vector * update metadata for cargo-ledger * cleanup build tooling * fix ci, hopefully * add llvm-tools to firmware build * fix package files * set nextest timeout --------- Co-authored-by: Sarah GLINER <sarah.gliner@ledger.fr> Co-authored-by: Sarah Gliner <105934250+sgliner-ledger@users.noreply.github.com> Co-authored-by: Alexis Grojean <111449109+agrojean-ledger@users.noreply.github.com> Co-authored-by: Alexis Grojean <alexis.grojean@ledger.fr> Co-authored-by: Lucas PASCAL <lucas.pascal@ledger.com> Co-authored-by: lpascal-ledger <94380347+lpascal-ledger@users.noreply.github.com> Co-authored-by: GroM <jerome.caporossi@gmail.com> Co-authored-by: GroM <jerome.caporossi@ledger.fr> Co-authored-by: Henry Holtzman <henry@mobilecoin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes upstream changes from ledger as well as #82