feat(ci): Setup CI, get e2e tests working #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lestack-runtime into jophish/test-branch
…lestack-runtime into jophish/test-branch
…lestack-runtime into jophish/test-branch
jophish
commented
Sep 12, 2024
| @@ -50,6 +50,9 @@ jobs: | |||
| yes | sdkmanager "platform-tools" "platforms;android-33" | |||
| set -o pipefail | |||
|
|
|||
| # Install Ninja | |||
There was a problem hiding this comment.
To be honest, I'm not certain why this is required here -- my best guess is that it's something to do with the cache volume, and this dependency somehow already being available in $PATH on the existing volume we use in the wallet. Since we're using a new volume for this repo, if this dep isn't installed during the setup process already, we wouldn't have it available.
Anyway, Detox was failing without it, so I added this here.
jophish
changed the title
jeanregisser
pushed a commit
that referenced
this pull request
Sep 25, 2024
### Description This PR gets the e2e tests working, and sets up the Namespace integration for the Android runners. ATM, all enabled e2e tests pass except for the WC tests, though this perhaps seems unrelated to this repo in particular? [See Slack thread](https://valora-app.slack.com/archives/C025V1D6F3J/p1726096062541629). ### Test plan <!-- Demonstrate the change is solid, or why it doesn't need testing. Example: add any manual testing steps or scenarios (if not obvious), screenshots / videos if the pull request changes the user interface. --> ### Related issues - Fixes #[issue number here] ### Backwards compatibility <!-- Brief explanation of why these changes are/are not backwards compatible. --> ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [ ] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gets the e2e tests working, and sets up the Namespace integration for the Android runners. ATM, all enabled e2e tests pass except for the WC tests, though this perhaps seems unrelated to this repo in particular? See Slack thread.
Test plan
Related issues
Backwards compatibility
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: