chore: disable some unnecessary CI workflows #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanregisser
approved these changes
Sep 11, 2024
| @@ -11,14 +11,14 @@ jobs: | |||
| uses: ./.github/workflows/release-fastlane-ios.yml | |||
| with: | |||
| branch: ${{ github.ref_name }} | |||
| lanes: '["alfajores", "mainnet"]' | |||
| lanes: '["mainnet"]' | |||
There was a problem hiding this comment.
This reminds, we should call it production and rename things accordingly in fastlane and .env.*
There was a problem hiding this comment.
oh yes, i can do this separately
jeanregisser
pushed a commit
that referenced
this pull request
Sep 25, 2024
### Description To keep the changes minimal, I've removed the automated triggers to the unnecessary workflows: - workflows related to crowdin and translations (these fail when doing the project syncs because of new translations that modify the localised files) - nightly builds - productions builds limited to only mainnet (skip alfajores) - licences update ### Test plan n/a ### Related issues n/a ### Backwards compatibility Y ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [ ] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To keep the changes minimal, I've removed the automated triggers to the unnecessary workflows:
Test plan
n/a
Related issues
n/a
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: