-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EU string support with fixed handling of emojis & other 4-byte UTF-8 chars on Android #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from cordova-sqlite-evcore-free-dependencies 0.9.1 (cordova-sqlite-evplus-ext-free 0.3.8)
starting version branch for additional EU character testing NOTE that this version branch is currently known to require slightly older Cordova CLI version such as cordova@8, cordova@7, or cordova@6 in order to install properly. This is due to use of an obsolete Cordova module. This is not an issue with recent versions of cordova-sqlite-storage itself or any of the other up-to-date version branches.
for: - Web SQL on Chrome desktop browser - plugin with androidDatabaseImplementation: 2 on Android 4.4 & newer
with some additional EU character testing NOTE that this version branch is currently known to require slightly older Cordova CLI version such as cordova@8, cordova@7, or cordova@6 in order to install properly. This is due to use of an obsolete Cordova module. This is not an issue with recent versions of cordova-sqlite-storage itself or any of the other up-to-date version branches.
Merge branch 'cordova-sqlite-storage-commoncore' of https://github.com/xpbrew/cordova-sqlite-storage
using functions from: * https://github.com/brodybits/sqlite3-eu with Android SQLite evcore-native-driver implementation built from: * https://github.com/litehelpers/Android-sqlite-evcore-native-driver-free/tree/sqlite3-eu-dev with fix for emojis and other 4-byte UTF-8 characters on Android 6(+) now with Android pre-6.0 no longer supported due to some possibly crashing tests SKIP some possibly crashing tests on Windows & Android, especially Android pre-6.0 (cordova-sqlite-evplus-ext-free 0.4.0-pre01)
This was referenced Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EU character support in UPPER & LOWER functions
using functions from:
with Android SQLite
evcore-native-driver
implementation built from:with fix for emojis and other 4-byte UTF-8 characters on Android 6.0(+)
now with Android pre-6.0 no longer supported due to some possibly crashing tests and other character handling issues
and with SQLite 3.28.0 update for all supported platforms Android, iOS, Windows, and mac OS ("osx")
SKIP some possibly crashing tests on Windows & Android, especially Android pre-6.0
Includes some new EU & emoji character tests merged in from
cordova-sqlite-storage-commoncore
version branch ofcordova-sqlite-storage
(with no additional code changes included).(cordova-sqlite-evplus-ext-free 0.4.0-pre01)
P.S. Here are some quick installation directions for testing purposes: