Add 2nd monotonic requirement; fixes subtle bug affecting some CCE outputs #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moble
reviewed
Jun 3, 2024
scri/SpEC/file_io/__init__.py
Outdated
Comment on lines
609
to
614
| time=WM_ref.t, | ||
| ell_max=WM_ref.ell_max, | ||
| time=WMs[list(WMs.keys())[0]].t, | ||
| ell_max=WMs[list(WMs.keys())[0]].ell_max, |
There was a problem hiding this comment.
Why not still just use WM_ref here? No copy was made, so WM_ref should have been changed in the same way, right?
There was a problem hiding this comment.
Good point; reverted back!
|
@moble not sure why the latest commit is causing |
|
I just made a commit that I thought should solve it, but I now realize won't do anything at all. In any case, this is possibly a bad test, and the failure certainly unrelated to this commit, so I'll just merge this and deal with any failures later. (Maybe I'll just disable the test if it keeps happening.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@moble should be an easy review; fixes a bug that occurs when the output CCE data has time steps with differences ~1e-15, which are set to zero when doing
-= float(radius)and screw up the monotonicity of the time array.