Enable eslint:recommended and prefer-arrow as error level with opt-in allowStandaloneDeclarations
#476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachick
force-pushed
the
drop-arrow-eslint-plugin
branch
from
0f3911a
to
6391939
Compare
pankona
reviewed
Jun 27, 2022
kachick
changed the title
eslint:recommended and drop eslint-plugin-prefer-arrow plugineslint:recommended and ~drop eslint-plugin-prefer-arrow plugin~ opt-in allowStandaloneDeclarations
kachick
changed the title
eslint:recommended and ~drop eslint-plugin-prefer-arrow plugin~ opt-in allowStandaloneDeclarationseslint:recommended and opt-in allowStandaloneDeclarations
kachick
changed the title
eslint:recommended and opt-in allowStandaloneDeclarationseslint:recommended and prefer-arrow as error level with opt-in allowStandaloneDeclarations
kachick
changed the title
eslint:recommended and prefer-arrow as error level with opt-in allowStandaloneDeclarationseslint:recommended and prefer-arrow as error level with opt-in allowStandaloneDeclarations
kachick
commented
Jun 28, 2022
pankona
approved these changes
Jun 28, 2022
|
Agree! Let's merge it! 😋 |
|
Thank you for approving my opinion 😤 I might change my mind in near feature 😋 |
kachick
added a commit
that referenced
this pull request
Jul 1, 2022
#486 (comment) This PR partially invert #476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pankona Do you think any merit of the plugin? That forces to use unfit syntax for type assertions. I guess we can opt-out it with
allowStandaloneDeclarationsoption, however dropping low merit dependency makes more good, I think.So this PR drops the dependency and enable built-in "eslint:recommended". It catched dangerous use of switch.