Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Looking for more maintainers 🚨 #700

Closed
mweststrate opened this issue Mar 14, 2018 · 51 comments
Closed

🚨 Looking for more maintainers 🚨 #700

mweststrate opened this issue Mar 14, 2018 · 51 comments
Labels
help/PR welcome Help/Pull request from contributors to fix the issue is welcome

Comments

@mweststrate
Copy link
Member

Hi all,

Over the pasts months it has become clear I don't have enough time to give MobX-state-tree the attention it deserves, which results in question remaining unanswered for too long. And although @robinfehr and @mattiamanzati stepped in, I think the package needs more maintainers.

I'm pretty sure there are many people who have more practical experience with the package then I have, so please step up if you have used this package with success so far!

If you find diving into the code base to scary, just answering open, common questions and triaging bug reports would already be a great help!

@Bnaya
Copy link
Member

Bnaya commented Mar 14, 2018

I'm always around :)

@mweststrate
Copy link
Member Author

@Bnaya, yes, noticed, and thanks for that! I've send an Github invite, that will make it even more easy :)

@luisherranz
Copy link
Member

We (@orballo, @DAreRodz and me) are migrating a big project from Redux to MST. We love MST and we'd sure love to contribute more to the project. But time on startups is always scarce and Typescript is a big drawback. Neither of us knows it, nor have the time to learn it right now. So we can't contribute to the code or answer Typescript related issues but we'll try to help with the other issues!! :)

@benjaminjackman
Copy link
Contributor

Hi! I have been using MST for a couple projects and it has been absolutely terrific so far. Sad to hear that development has stalled on it but that’s how stuff goes, to much to do too little time, thanks for all the hard work getting it here!

I’ve been working on a .d.ts type declaration wrapper around MST that uses the upcoming Typescript 2.8 conditional types to improve type safety.

I can look around to see if there is any open tickets on that (on mobile at the moment) and try to help there since it has definitely been a huge improvement to typesafety in the projects I have been testing it out in. In general I could definitely help out with Typescript expertise if that’s needed.

What is the best way to step up?

@caesarsol
Copy link
Contributor

Hi @mweststrate, I don't have much time either but I'll stay around as well!
I can help in triaging bug reports and reviewing PRs for now, will try to drop some code in the future.

@Bnaya
Copy link
Member

Bnaya commented Mar 15, 2018

@benjaminjackman would love to see your progress on that!

@benjaminjackman
Copy link
Contributor

benjaminjackman commented Mar 15, 2018

@Bnaya I made an issue for using Conditional Types #705 My implementation is still really more of a rough draft. I am able to use it for a couple of my projects but I need to clean it up quite a bit.

Update: I've made a package h-mst that facades the import {types} from ... and published it here: https://yarnpkg.com/en/package/h-mst

@KBorders01
Copy link

We are in the process of refactoring our main application to MST at Collage.com. Some of us may be able to contribute, but we are new to MST right now. We are particularly interested in helping with any performance optimizations.

@mweststrate
Copy link
Member Author

Hey folks!

Thanks for all the positive responses! Really encouraging :) Everyone who responded above should have gotten a maintainers invite to this repository. Which means you will have full control over issues, and can push code, create branches etc. (Especially the last is way easier for collaboration then running your own forks)!

@robinfehr and me are currently compiling an overview of the status of the repo, and that should help to address any open issues in a more organized manner. Don't worry, there will be enough things to choose from :)

@jk-gan
Copy link

jk-gan commented Mar 21, 2018

We are migrating our React app to MST in my company and we love it. I'm new to Typescript right now but I'm interested to contribute to the project.

@danpan1
Copy link

danpan1 commented Apr 12, 2018

how can i help you with project? always wanted to take part in OSS for growing developer skills. danpan@yandex.ru

@robinfehr
Copy link
Contributor

@danpan1 https://github.com/mobxjs/mobx-state-tree/projects/1 here you can find issues which are good to chime in :)

@alexvcasillas
Copy link
Contributor

I'll try to help with whatever I can in terms of usage and practical experience.
I'm also going to give a try to dive into the code base to see if I'm able to help with something!

@mweststrate
Copy link
Member Author

mweststrate commented May 31, 2018 via email

@mweststrate
Copy link
Member Author

Is someone interested in occasionally compiling a changelog and pushing a release to NPM?

@stariqmi
Copy link

stariqmi commented Jun 9, 2018

@mweststrate can I help? I've always wanted to help and grow by contributing to OSS :)

@mweststrate
Copy link
Member Author

@stariqmi I hope! I am looking for someone who can monitor the open pull requests;

  • Are they ready to be merged?
  • Is there a changelog issue item linking to the PR, committer, and relevant issues?
  • Is the proposed change breaking or non-breaking?
  • Occasionally cut a release. Patches can always be released, breaking changes need coordination :-).
  • Occasionally ping either a reviewer or PR submitter if progress is stalled :-).

Let me know if you are interested, then I'll send you the necessary invites.

Thanks!

@stariqmi
Copy link

@mweststrate I am down for it!

@mweststrate
Copy link
Member Author

@stariqmi! Cool! added you to the organization. If you need npm rights just send me your npm username :)

@stariqmi
Copy link

@mweststrate - thank you! my npm username is stariqmi as well :)

@mweststrate
Copy link
Member Author

Hi folks! I made a rough roadmap for MST 3.0: https://github.com/mobxjs/mobx-state-tree/projects/2

So feel free to take a look in the things in the Todo lane and

  1. Read it and place comments if you have doubts or think it is an awesome idea :)
  2. If you feel for it, feel free to assign your own name to a story and pick it up!

I hope to spawn of a 3.0 branch ~tomorrow.

Thanks in advance!

@mweststrate
Copy link
Member Author

Also, if you feel anything is missing, feel free to bring it up, and open an issue to discuss it!

@JoviDeCroock
Copy link

I think it would come in handy to set up a little guide on how to get started as a contributor, this could be a minimal setup guide for the project: how to get tests working, ... and maybe even a high level description about what file/folder handles what concern.

@mweststrate
Copy link
Member Author

mweststrate commented Jun 28, 2018 via email

@chemitaxis
Copy link
Contributor

Hi @mweststrate like you know we use MST in our product every day... and it’s time to help this project. Like @JoviDeCroock said, it would be amazing have a tutorial for starting to help. You use vscode normally, right? Prettier or something? It would be nice if you share the configuration of your editor and so staring and don’t waste time in these typical stuff. What do you think? Do I need to request an special access? I have contributed in other OSS projects. Thanks!

@mweststrate
Copy link
Member Author

@chemitaxis @JoviDeCroock I updated the contributions guide: https://github.com/mobxjs/mobx-state-tree/tree/mst3#contributing. Hope it helps, and otherwise feel free to ask / PR any clarification!

Also, don't forget to keep an eye on https://spectrum.chat/mobx-state-tree!

@chemitaxis
Copy link
Contributor

chemitaxis commented Jul 12, 2018 via email

@xaviergonz xaviergonz added the help/PR welcome Help/Pull request from contributors to fix the issue is welcome label Aug 18, 2018
@shawnaxsom
Copy link

Are more maintainers still needed? While I am new to MobX State Tree, I've really enjoyed working on MobX itself on a few projects. I would be happy to help.

@mweststrate
Copy link
Member Author

@shawnaxsom sure, all help is welcome! (sorry for late response, with enough projects Github notifications are useless, so I often miss new messages).

The easiest way to get started is to just browse through the issues, answer question or self assign stuff. If you have specific things you want to contribute, just let us know!

@mweststrate
Copy link
Member Author

mweststrate commented Jan 15, 2019

I think we can close the issue for now, as @xaviergonz and @k-g-a (and several individual contributors) have been doing an awesome job lately, and issues are being addressed consistently. Thanks for all the efforts guys!

Beyond that, I'm planning to dedicate some significant time next month to the project, to investigate whether we can offer first class support for GraphQL and and XState (ideas and existing project references are welcome! (but as separate issue plz).

Anyway, for everybody contributing: I hear lot of super happy testimonials about the project on twitter and in the egghead course. To share a couple:

screenshot from 2019-01-15 10-19-35
screenshot from 2019-01-15 10-22-54

Obviously, more maintainers are always welcome! Feel free to reply to this thread to get an invite!

@ravides19
Copy link

@mweststrate I am also in for active contribution, I love MST made my life so easy on many projects.

@mweststrate
Copy link
Member Author

@krezicoder awesome! I'll add you as maintainer. The most valuable contribution at this moment is probably helping people out with questions, but feel free to pick anything that peeks your interest :)

@mweststrate
Copy link
Member Author

mweststrate commented Sep 24, 2019 via email

@mweststrate
Copy link
Member Author

Re-opening this issue :) Could definitely use some more maintainers atm!

@mweststrate mweststrate reopened this Apr 15, 2020
@mweststrate mweststrate pinned this issue Apr 15, 2020
@FabriceReynolds
Copy link

I'm up for helping as I really like MST and would love to give back :)

@shawnaxsom
Copy link

shawnaxsom commented Apr 16, 2020 via email

@mweststrate
Copy link
Member Author

Awesome @FabriceReynolds & @shawnaxsom! The simplest way to get started is to dive into open issues and answer questions there and on https://spectrum.chat/mobx-state-tree. A lot of questions are about usage patterns, where your experiences could really help.

Further there are minor bugs reported, that deserves addressing, so feel free up to put up PRs that verify or fix those! So there is nothing blocking from getting started right away. Usually I hand out more permissions once you need, so feel free to reach out as soon as you need them! For example, once you have multiple PRs, or want to close / moderate issues, maintainer permissions come in really useful!

@diegochavez
Copy link
Collaborator

Awesome :D I'll be here for help 👍

@mweststrate
Copy link
Member Author

Awesome! Enough open issues to get started with! 😅 (if they are too old, they can probably just be closed)

@CmplxStack
Copy link
Collaborator

@mweststrate Hey, if additional maintainers are still needed I'd love to contribute! I've been having a great time helping with and advocating for all things mobx at work so the opportunity to help more just sounds like fun!

@mweststrate
Copy link
Member Author

@CmplxStack that is awesome! First of all it'd be great if someone would take further care of #1569; testing, verifying and eventually releasing it :). Secondly there are a lot of issues that go unanswered now, being stale, valid bugs or answering the questions in there would be really great.

@zuhair-naqvi
Copy link
Collaborator

zuhair-naqvi commented Oct 3, 2020

Used MST for several React Native apps. This is an awesome project that deserves much love, happy to help as a part time maintainer.

Particularly interested in #1569 - feel free to assign

@mweststrate
Copy link
Member Author

Did send invites! @zuhair-naqvi I'll reassign once accepted. Thanks!

@orlovcs
Copy link
Collaborator

orlovcs commented Oct 5, 2020

@mweststrate MST has made life much easier, I'd be happy to help!

@mweststrate
Copy link
Member Author

Awesome, #1569 or even processing any of the open PRs would be a great start!

@jesse-savary
Copy link
Member

Hey, both @orlovcs and myself are looking to help out with MST.

We've been using it in for over the last year and it's been a massive time saver. Our whole app is structured around it and I've been looking for an opportunity to contribute back to Mobx(-State-Tree) as a company/developer.

I can confirm that Mobx 6 is working great for us without any need to change our code. I'll start poking through other PRs but is there anything in particular that needs to be done to get the release candidate out the door? I'm not entirely familiar with how your process works :)

@jesse-savary
Copy link
Member

Hey @mweststrate, it's been a couple weeks now and I've reviewed a few PRs. I was recently tagged on one that has been open for quite some time but contains good code: #1540

What will it take for this PR and others to be merged?

@mweststrate
Copy link
Member Author

@jesse-savary apologies, thought I had sent out invites already! Feel free to merge those you are comfortable with :). Releases can be coordinated with @Bnaya or @jamonholmgren. Thanks and sorry for the late follow up!

@jesse-savary
Copy link
Member

No worries, I've accepted the invited now. Thank you very much!

@jamonholmgren
Copy link
Collaborator

@jesse-savary @Bnaya Looking forward to coordinating with you folks!

@jamonholmgren
Copy link
Collaborator

I think we can call this one "fixed". :-)

https://twitter.com/jamonholmgren/status/1331692221289041920

@jamonholmgren jamonholmgren unpinned this issue Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help/PR welcome Help/Pull request from contributors to fix the issue is welcome
Projects
None yet
Development

No branches or pull requests