Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make getEnv fail when root has not been initialized with context #820

Closed
mweststrate opened this issue May 16, 2018 · 1 comment · Fixed by #2163
Closed

make getEnv fail when root has not been initialized with context #820

mweststrate opened this issue May 16, 2018 · 1 comment · Fixed by #2163
Labels
breaking change Breaking change has PR A Pull Request to fix the issue is available

Comments

@mweststrate
Copy link
Member

give a clear error with what root (type) it didn't find an environment for. This will make getEnv fail if it is used to early, for example in afterCreate instead of afterAttach
@mweststrate mweststrate added enhancement Possible enhancement level: easy help/PR welcome Help/Pull request from contributors to fix the issue is welcome and removed enhancement Possible enhancement labels Jun 18, 2018
@PMExtra
Copy link

PMExtra commented Jul 6, 2018

I have the same problem. I want to refresh some data when the store created. But the api in environment has not initialed.

@t49tran t49tran mentioned this issue Jul 20, 2018
Closed
@xaviergonz xaviergonz added breaking change Breaking change has PR A Pull Request to fix the issue is available and removed help/PR welcome Help/Pull request from contributors to fix the issue is welcome level: easy labels Oct 13, 2018
@xaviergonz xaviergonz mentioned this issue Mar 10, 2019
Closed
@coolsoftwaretyler coolsoftwaretyler mentioned this issue Jul 3, 2023
Closed
@coolsoftwaretyler coolsoftwaretyler mentioned this issue Mar 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Breaking change has PR A Pull Request to fix the issue is available
Projects
None yet
Milestone
No milestone
3 participants
@mweststrate @xaviergonz @PMExtra