Feat/has env and getenv changes #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Supercedes #2039, which was a re-write of #938.
This is a breaking change. We approved it a long time ago, but have dramatically changed the file structure of the repo along the way. No longer requires us to update the middlewares (since those are not in the repository anymore).
We'll ship this along with version 6.0.0, which has a few other minor breaking changes.
Closes #820
Steps to validate locally
Test should pass.
getEnvnow throws when one is not found, and we have ahasEnvfunction you can use to check if there is one or not. This makes thegetEnvAPI more consistent with things likegetParentandgetRoot, which also throw when there is none found.