applyPatch replace root of store if path is empty #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@epodgaetskiy I'm taking over as primary maintainer on MST. What's the status on this PR? Still feel like it should be pushed through? Looks like there are some conflicts. |
|
@jamonholmgren Fixed conflicts. |
|
@jamonholmgren PR is ready for merging |
jamonholmgren
approved these changes
Dec 18, 2020
jamonholmgren
added
next-release
|
We will actually wait for next major version since this could be a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to fix #1411
Using the recommendation replace the entire structure