Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for mst-query #2170

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Docs for mst-query #2170

merged 4 commits into from
Jul 4, 2024

Conversation

k-ode
Copy link
Contributor

@k-ode k-ode commented Mar 27, 2024

This is just a draft pr to track my work on creating docs for mst-query.

Feel free to leave comments!

@coolsoftwaretyler
Copy link
Collaborator

Thanks @k-ode! Let me know when you're ready for review.

If you get a chance, will you please consider adding this in the "recipes" section, rather than the tips? I think these sort of extra ecosystem tools make sense in the format of "what problem did I need to solve, and here's how I solved it"

@k-ode k-ode force-pushed the docs/mst-query branch from e6552ad to 33dc86d Compare July 3, 2024 13:43
@k-ode k-ode force-pushed the docs/mst-query branch from 33dc86d to 8d14d9e Compare July 3, 2024 13:50
@k-ode k-ode marked this pull request as ready for review July 3, 2024 13:51
@k-ode
Copy link
Contributor Author

k-ode commented Jul 3, 2024

@coolsoftwaretyler This took a while 😅 But it's ready for review now.

@coolsoftwaretyler
Copy link
Collaborator

Thanks @k-ode! I'll take a look soon. Really appreciate your time here.

Copy link
Collaborator

@coolsoftwaretyler coolsoftwaretyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-ode - this is phenomenal!

The only thing we're missing is a link to mst-query. Should we link to:

  1. The GitHub: https://github.com/ConrabOpto/mst-query
  2. npm: https://www.npmjs.com/package/mst-query
  3. Somewhere else?

Let me know, then we can add that and ship this to the docs site!

@k-ode
Copy link
Contributor Author

k-ode commented Jul 4, 2024

@coolsoftwaretyler I added a link to GitHub.

@coolsoftwaretyler
Copy link
Collaborator

Updated the title to be a little clearer, but other than that I think we're good to go. Will merge and deploy. Thanks so much, @k-ode! Feel free to submit additional PRs if you ever need to want things up to date.

@coolsoftwaretyler coolsoftwaretyler merged commit 030cb3b into mobxjs:master Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants