fix: revert 2218 to fix ts excessively deep types #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
This PR closes #2230, by reverting #2218. That means we'll have to repoen #2216, unfortunately.
In the long term, we'll want to fix these types at the root of the repository. But since we don't have a full roadmap for that, we are going to make a practical choice to prioritize fixing #2230 over fixing #2216.
For anyone who prefers the older fix, you can either patch the package yourself, or run from
v7.0.0, which will still be available and have #2218 available in its source code.Steps to validate locally
Tests should pass, old behavior should be restored. I have modified
__tests__/core/2230.test.tsto include all of the reproducing code from #2230.